commit 8c06c9ab6944e4611565c424b6a8e6dcf2a5ea06 Author: Philip Withnall Date: Sat Dec 11 21:46:23 2010 +0000 docs: Add missing documentation to the table of contents docs/reference/gdata-docs.xml | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) commit 972d20d1f2b0b4487f549dcfebaa8e4899f5ce52 Author: Philip Withnall Date: Sat Dec 11 20:12:03 2010 +0000 tests: Fix comparison of attributes' namespaces in XML tree comparisons gdata/tests/common.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 782a7a1cbd613de08b47d639f3d72eb678cb9bd0 Author: Philip Withnall Date: Sat Dec 11 19:13:22 2010 +0000 documents: Actually store the content-type notification signal handler ID This is the third commit to fix this trivial problem. I need more sugar. gdata/services/documents/gdata-documents-entry.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 3e56180c9aec72eee4915bc57f192e867d252148 Author: Philip Withnall Date: Sat Dec 11 14:38:00 2010 +0000 tests: Convert all the tests to use the new XML tree comparison function This fixes them to work correctly regardless of the GLib version. gdata/tests/calendar.c | 15 +--- gdata/tests/contacts.c | 5 +- gdata/tests/general.c | 193 ++++++++++++----------------------------------- gdata/tests/picasaweb.c | 59 +++++++------- gdata/tests/youtube.c | 10 +-- 5 files changed, 83 insertions(+), 199 deletions(-) commit 088243fe2725150c551d602e21da5d1ff4a3c243 Author: Philip Withnall Date: Sat Dec 11 11:53:55 2010 +0000 tests: Add an XML tree comparison function for the test suite Due to a recent change in GLib master which affects the ordering of entries in hash tables (g_str_hash()'s implementation has been changed), many of the XML comparisons in libgdata's test suite have been broken. A tidy solution is to introduce an XML-aware comparison function, rather than just using a simple string comparison. This commit does that. This commit only adds the comparison function; a further one will port all the test suites to use it. gdata/tests/Makefile.am | 2 +- gdata/tests/common.c | 205 +++++++++++++++++++++++++++++++++++++++++++++++ gdata/tests/common.h | 12 +++ gdata/tests/general.c | 172 +++++++++++++++++++++++++++++++++++++++ 4 files changed, 390 insertions(+), 1 deletions(-) commit a36d325ba97b12ed9a5ebd3336ea41a2a9a356ab Author: Philip Withnall Date: Sat Dec 11 01:02:20 2010 +0000 picasaweb: Fix the number of albums used by the tests gdata/tests/picasaweb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 64a2294e175a2548be8981753fd4325846c08670 Author: Philip Withnall Date: Sat Dec 11 01:00:40 2010 +0000 tests: Fix the escaping tests gdata/tests/general.c | 9 --------- 1 files changed, 0 insertions(+), 9 deletions(-) commit c72951bc350b445bb1fb509329b9c6bc4e0a733c Author: Philip Withnall Date: Sat Dec 11 00:48:57 2010 +0000 core: Revert signedness changes to GDataQuery The changes were a fix for a problem introduced by an API break in the 0.7 branch, and weren't appropriate for the 0.6 branch. This reverts the following commits: • 22892b635b6399b23c477df943b5c5afd112e1ad • 548eae618bf2d6cb3a572c908840b90d3cb6dd2b gdata/gdata-query.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit b25a0a48b3493885dc4101c7fe39e4d0d569b440 Author: Philip Withnall Date: Sat Dec 11 00:40:17 2010 +0000 youtube: Fix the XML for aspect ratios gdata/services/youtube/gdata-youtube-group.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit 62cf2ea6a20f30bc644527e491d0b9765ccdd832 Author: Philip Withnall Date: Fri Dec 10 22:35:57 2010 +0000 documents: Disconnect from the content-type notification signal We can't change GDataDownloadStream to emit notification signals for content-type in the download thread in the 0.6 branch, since that would be an API break. This means that the notifications could potentially be delivered after _gdata_documents_entry_download_document() returns. Since the closure for the notification idle function maintains a reference to the GDataDownloadStream, this means that the signal handler won't be disconnected automatically once the GDataDownloadStream is unreffed in _gdata_documents_entry_download_document(). Consequently, it's possible to get invalid writes into random bits of memory unless we disconnect from the content-type notification signal. This commit does that. gdata/services/documents/gdata-documents-entry.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) commit dcc7f4b08d76c31298d6ee6225c4a278bc9996af Author: Philip Withnall Date: Fri Dec 10 16:49:25 2010 +0000 youtube: Fix a crash in the error handling code if no GError is passed in gdata/services/youtube/gdata-youtube-service.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit 9264f8a99b21d6808f6a33ac31649ea2c0bd263a Author: Philip Withnall Date: Fri Dec 10 12:12:40 2010 +0000 picasaweb: Fix memory leaks in the picasaweb test suite gdata/tests/picasaweb.c | 20 ++++++++++++++++++-- 1 files changed, 18 insertions(+), 2 deletions(-) commit 895c0483115ffcd675d8f7394bb31ade80eecffa Author: Philip Withnall Date: Fri Dec 10 12:12:17 2010 +0000 picasaweb: Fix a memory leak in GDataPicasaWebService gdata/services/picasaweb/gdata-picasaweb-service.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) commit fa0325d5b6f7b63de3225a417f2fbf8b2f2ee64e Author: Philip Withnall Date: Fri Dec 10 11:54:43 2010 +0000 picasaweb: Update test URIs It appears that the test account on PicasaWeb has been moved to a different server, so we need to update a few URIs in the tests accordingly. gdata/tests/picasaweb.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit 59e1ef8df222f4973bb3003b201b28b021aeeb4e Author: Philip Withnall Date: Fri Dec 10 11:44:22 2010 +0000 tests: Fix memory leaks in the general test suite gdata/tests/general.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit 5a0651135e2e0a58f126781acdb11f41855ad4e1 Author: Philip Withnall Date: Fri Dec 10 11:30:43 2010 +0000 contacts: Fix a leak in GDataContactsContact gdata/services/contacts/gdata-contacts-contact.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) commit 528813323367a3a8f4ea42ef765d640c664e6752 Author: Philip Withnall Date: Fri Dec 10 10:46:29 2010 +0000 calendar: Fix memory leaks in the calendar test suite gdata/tests/calendar.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) commit a11c03983bf79065082db2b899424422c5706a7c Author: Philip Withnall Date: Fri Dec 10 01:59:20 2010 +0000 core: Fix a major memory leak in GDataDownloadStream It turns out that we were leaking the entirety of every file downloaded using a GDataDownloadStream. Whoops. gdata/gdata-download-stream.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 1237d8f5f526ca7884b07b930fe0b0f6aa223ad4 Author: Philip Withnall Date: Thu Dec 9 19:01:32 2010 +0000 documents: Fix some memory leaks in the documents test suite gdata/tests/documents.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) commit dc199e53e4fbd0c1411c6455a2979c05edf10c08 Author: Philip Withnall Date: Thu Dec 9 18:46:39 2010 +0000 documents: Fix a memory leak in GDataDocumentsQuery gdata/services/documents/gdata-documents-query.c | 21 +++++++++++++++++++++ 1 files changed, 21 insertions(+), 0 deletions(-) commit 664b383effce331d347edb36d13b44e4e3b44327 Author: Philip Withnall Date: Thu Dec 9 18:16:56 2010 +0000 documents: Don't return a content type if a return location wasn't provided gdata/services/documents/gdata-documents-entry.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) commit 06f1ba9b8a85b09e2a76004008129d004ec93900 Author: Philip Withnall Date: Wed Dec 1 20:45:03 2010 +0000 Bug 635736 — Asynchronous authentication tests broken The asynchronous authentication tests have been broken for a while, probably caused due to changes of asynchronous callback functions within GIO. We previously depended on an idle function to set the username and password after a successful asynchronous authentication, but due to the priority changes this has stopped being called before the asynchronous result callback, meaning that the results of authentication weren't available to the callback. This made it look like authentication had failed, when in reality it had succeeded and the results were waiting in the main loop's queue. This changes it so that the authentication information in GDataService is set inside the authentication thread, protected by a mutex. Closes: bgo#635736 gdata/gdata-service.c | 31 +++++++++++++++++++++++++++++++ 1 files changed, 31 insertions(+), 0 deletions(-) commit 67bd5884b39c2cb88281e8a199db953db679a48d Author: Philip Withnall Date: Thu Dec 2 18:06:15 2010 +0000 youtube: Emit XML for a video's aspect ratio gdata/services/youtube/gdata-youtube-group.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) commit 548eae618bf2d6cb3a572c908840b90d3cb6dd2b Author: Philip Withnall Date: Sat Nov 27 23:12:36 2010 +0000 core: Store the start index as an unsigned int in GDataQuery The external interface was accepting unsigned values, but was storing them as signed internally. gdata/gdata-query.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 22892b635b6399b23c477df943b5c5afd112e1ad Author: Philip Withnall Date: Sat Nov 27 21:51:34 2010 +0000 core: Store the maximum number of results as an unsigned int in GDataQuery The external interface was accepting unsigned values, but was storing them as signed internally, leading to interesting things happening when G_MAXUINT was passed as max-results, as recommended by the documentation. gdata/gdata-query.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit c93b14d47ed17ccd3edab6932cadb14db075d97a Author: Philip Withnall Date: Mon Oct 4 10:50:04 2010 +0100 introspection: Skip gdata_service_query_async() Its progress_callback parameter was incorrectly marked as (scope async), which could cause crashes in the bindings. It will have to be skipped. gdata/gdata-service.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit fd0cc728f07aada55a26e4b007d410933b478af5 Author: Philip Withnall Date: Thu Sep 30 19:17:59 2010 +0100 gd: Fix attribute escaping for GDataGDWho gdata/gd/gdata-gd-who.c | 4 ++-- gdata/tests/general.c | 21 +++++++++++++++++++++ 2 files changed, 23 insertions(+), 2 deletions(-) commit 203c9e20e84ac294adc09548bd0e0c4ce8855136 Author: Philip Withnall Date: Thu Sep 30 19:13:30 2010 +0100 gd: Fix attribute escaping for GDataGDWhere gdata/gd/gdata-gd-where.c | 2 +- gdata/tests/general.c | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+), 1 deletions(-) commit e82278624b40a108d095a56ae29011c003b75652 Author: Philip Withnall Date: Thu Sep 30 19:09:55 2010 +0100 gd: Fix attribute escaping for GDataGDWhen gdata/gd/gdata-gd-when.c | 2 +- gdata/tests/general.c | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+), 1 deletions(-) commit eb8e779c92d315883c4898c6a44e412cd2b4a92b Author: Philip Withnall Date: Thu Sep 30 19:05:13 2010 +0100 gd: Fix attribute escaping for GDataGDReminder gdata/gd/gdata-gd-reminder.c | 2 +- gdata/tests/general.c | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 1 deletions(-) commit 07ac04cc8b5597090caabdc9053baa5d45e408b4 Author: Philip Withnall Date: Thu Sep 30 18:59:10 2010 +0100 gd: Fix attribute escaping for GDataGDPostalAddress gdata/gd/gdata-gd-postal-address.c | 2 +- gdata/tests/general.c | 46 ++++++++++++++++++++++++++++++++++++ 2 files changed, 47 insertions(+), 1 deletions(-) commit 81fb66634a555150ca61d09cd18909a4300a639f Author: Philip Withnall Date: Thu Sep 30 18:44:07 2010 +0100 gd: Fix attribute escaping for GDataGDPhoneNumber gdata/gd/gdata-gd-phone-number.c | 4 ++-- gdata/tests/general.c | 21 +++++++++++++++++++++ 2 files changed, 23 insertions(+), 2 deletions(-) commit 2424d6748b01e9220f29a29c94e400819b400f36 Author: Philip Withnall Date: Thu Sep 30 17:31:48 2010 +0100 gd: Fix attribute escaping for GDataGDOrganization gdata/gd/gdata-gd-organization.c | 2 +- gdata/tests/general.c | 29 +++++++++++++++++++++++++++++ 2 files changed, 30 insertions(+), 1 deletions(-) commit 9666fec57e089859a876c47def93636f1ea09386 Author: Philip Withnall Date: Thu Sep 30 17:23:46 2010 +0100 gd: Fix attribute escaping for GDataGDIMAddress gdata/gd/gdata-gd-im-address.c | 7 +++---- gdata/tests/general.c | 21 +++++++++++++++++++++ 2 files changed, 24 insertions(+), 4 deletions(-) commit 16fe5f793ea94d47966d3ec67a36c1476196e009 Author: Philip Withnall Date: Thu Sep 30 17:10:12 2010 +0100 gd: Fix attribute escaping for GDataGDEmailAddress Add a test case for it too. Closes: bgo#630350 gdata/gd/gdata-gd-email-address.c | 4 ++-- gdata/tests/general.c | 23 +++++++++++++++++++++++ 2 files changed, 25 insertions(+), 2 deletions(-) commit f2dffa2e26efd6106a8ec0803268fab9c680e247 Author: Philip Withnall Date: Thu Sep 30 14:09:10 2010 +0100 Release version 0.6.5 NEWS | 11 +++++++++++ configure.ac | 4 ++-- 2 files changed, 13 insertions(+), 2 deletions(-)